Ensure valid TraitRefs are created for GATs #82066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Also make sure that type arguments of associated types are printed in some error messages.
matthewjasper
force-pushed
the
trait-ref-fix
branch
from
73cd992 to
eeb82e4
Compare
|
Hmm, I actually have a much more minimal variation of this done: jackh726@7caf640 Looking through this, there seems to be a lot more here. Need to look through and see how it's different. |
jackh726
approved these changes
Feb 13, 2021
|
@bors r+ |
|
📌 Commit eeb82e4 has been approved by |
bors
added
S-waiting-on-bors
taralx
reviewed
Feb 15, 2021
| @@ -0,0 +1,17 @@ | |||
| // Test that correct syntax is used in suggestion to constrain associated type | |||
|
|
|||
| #![feature(generic_associated_types)] | |||
There was a problem hiding this comment.
Out of curiosity, why not #![allow(incomplete_features)] in these? It's still one line and clears up the .stderr view.
There was a problem hiding this comment.
imo, #![allow(incomplete_features)] could be missed later on when this is no longer an incomplete feature and it could be removed. So, personally, I prefer to just have the warning in the stderr files now and have it removed later.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 16, 2021
…h726 Ensure valid TraitRefs are created for GATs This fixes `ProjectionTy::trait_ref` to use the correct substs. Places that need all of the substs have been updated to not use `trait_ref`. r? `@jackh726`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 17, 2021
…h726 Ensure valid TraitRefs are created for GATs This fixes `ProjectionTy::trait_ref` to use the correct substs. Places that need all of the substs have been updated to not use `trait_ref`. r? ``@jackh726``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 18, 2021
…h726 Ensure valid TraitRefs are created for GATs This fixes `ProjectionTy::trait_ref` to use the correct substs. Places that need all of the substs have been updated to not use `trait_ref`. r? ```@jackh726```
This was referenced Feb 18, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 18, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#81546 ([libtest] Run the test synchronously when hitting thread limit) - rust-lang#82066 (Ensure valid TraitRefs are created for GATs) - rust-lang#82112 (const_generics: Dont evaluate array length const when handling yet another error ) - rust-lang#82194 (In some limited cases, suggest `where` bounds for non-type params) - rust-lang#82215 (Replace if-let and while-let with `if let` and `while let`) - rust-lang#82218 (Make sure pdbs are copied along with exe and dlls when bootstrapping) - rust-lang#82236 (avoid converting types into themselves (clippy::useless_conversion)) - rust-lang#82246 (Add long explanation for E0549) - rust-lang#82248 (Optimize counting digits in line numbers during error reporting) - rust-lang#82256 (Print -Ztime-passes (and misc stats/logs) on stderr, not stdout.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
ProjectionTy::trait_refto use the correct substs. Places that need all of the substs have been updated to not usetrait_ref.r? @jackh726